Skip to content

Conversation

@juliohm
Copy link
Member

@juliohm juliohm commented Oct 2, 2025

Makes it explicit in the compat section. Our tests are already correct.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 9a6416a... master / 9a6416a...
clipping/SutherlandHodgman 3.71 ± 0.15 μs 3.71 ± 0.15 μs 1 ± 0.057
discretization/simplexify 27.1 ± 1.3 ms 27.3 ± 1.5 ms 0.996 ± 0.073
intersection/ray-triangle 0.05 ± 0.01 μs 0.05 ± 0.01 μs 1 ± 0.28
sideof/ring/large 6.53 ± 0.01 μs 6.53 ± 0.01 μs 1 ± 0.0022
sideof/ring/small 0.05 ± 0.001 μs 0.05 ± 0.001 μs 1 ± 0.028
topology/half-edge 2.75 ± 0.049 ms 2.71 ± 0.037 ms 1.02 ± 0.023
winding/mesh 0.0429 ± 0.0013 s 0.0431 ± 0.0017 s 0.995 ± 0.049
time_to_load 1.46 ± 0.0043 s 1.47 ± 0.015 s 0.992 ± 0.01
Memory benchmarks
master 9a6416a... master / 9a6416a...
clipping/SutherlandHodgman 0.053 k allocs: 4.97 kB 0.053 k allocs: 4.97 kB 1
discretization/simplexify 0.226 M allocs: 21.8 MB 0.226 M allocs: 21.8 MB 1
intersection/ray-triangle 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
topology/half-edge 18.1 k allocs: 2.92 MB 18.1 k allocs: 2.92 MB 1
winding/mesh 0.231 M allocs: 23 MB 0.231 M allocs: 23 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Benchmark Results (Julia v1)

Time benchmarks
master 9a6416a... master / 9a6416a...
clipping/SutherlandHodgman 3.41 ± 0.21 μs 3.38 ± 0.22 μs 1.01 ± 0.091
discretization/simplexify 24.7 ± 4 ms 24.8 ± 4 ms 0.996 ± 0.23
intersection/ray-triangle 0.06 ± 0.01 μs 0.06 ± 0 μs 1 ± 0.17
sideof/ring/large 6.84 ± 0.02 μs 6.78 ± 0.091 μs 1.01 ± 0.014
sideof/ring/small 0.06 ± 0.01 μs 0.06 ± 0.01 μs 1 ± 0.24
topology/half-edge 2.81 ± 0.14 ms 2.85 ± 0.29 ms 0.987 ± 0.11
winding/mesh 0.0422 ± 0.0027 s 0.0429 ± 0.0031 s 0.983 ± 0.094
time_to_load 1.55 ± 0.0069 s 1.52 ± 0.04 s 1.02 ± 0.027
Memory benchmarks
master 9a6416a... master / 9a6416a...
clipping/SutherlandHodgman 0.053 k allocs: 4.83 kB 0.053 k allocs: 4.83 kB 1
discretization/simplexify 0.324 M allocs: 21.8 MB 0.324 M allocs: 21.8 MB 1
intersection/ray-triangle 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
topology/half-edge 20.8 k allocs: 2.92 MB 20.8 k allocs: 2.92 MB 1
winding/mesh 0.329 M allocs: 22.9 MB 0.329 M allocs: 22.9 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.86%. Comparing base (db4881f) to head (9a6416a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         196      196           
  Lines        6181     6181           
=======================================
  Hits         5431     5431           
  Misses        750      750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm juliohm merged commit eeedffa into master Oct 2, 2025
18 checks passed
@juliohm juliohm deleted the julia-lts branch October 2, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants